Re: [PATCH v3 08/13] drm: bridge: samsung-dsim: Add module init, exit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marek,

On Thu, Jul 21, 2022 at 4:39 PM Marek Szyprowski
<m.szyprowski@xxxxxxxxxxx> wrote:
>
> Hi Jagan,
>
> On 20.07.2022 17:52, Jagan Teki wrote:
> > Add module init and exit functions for the bridge to register
> > and unregister dsi_driver.
> >
> > Exynos drm driver stack will register the platform_driver separately
> > in the common of it's exynos_drm_drv.c including dsi_driver.
> >
> > Register again would return -EBUSY, so return 0 for such cases as
> > dsi_driver is already registered.
>
> I've already pointed that this is a bad style solution. It will also not
> work in the following cases:

Yes, I have seen it in v2. (sending again since its part of the series
and resolved other issues on v2)

>
> 1. exynos drm and samsung-dsim compiled as modules - samsung-dsim
> module, once loaded, will register the driver and exynos_drm won't be
> able to register the exynos_dsi.
>
> 2. multi-arch case - if one compiles a kernel (disto-style) with drivers
> for both supported architectures (exynos and imx) - in such case it will
> not work on imx, because exynos_drm driver will always register
> exynos_dsi driver first (even if the kernel is booted on non-exynos board).

Okay. I need to check the best way to handle this - so far this seems
new. any suggestions, please let me know.

Thanks,
Jagan.



[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux for Synopsys ARC Processors]    
  • [Linux on Unisoc (RDA Micro) SoCs]     [Linux Actions SoC]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  •   Powered by Linux