On 06/07/2022 12:54, Chanho Park wrote: >>> When running dtbs_check I found: >>> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: phy@17e04000: clocks: >>> [[10]] is too short >>> >>> From schema: Documentation/devicetree/bindings/phy/samsung,ufs- >> phy.yaml >>> >>> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: phy@17e04000: >>> clock-names: ['ref_clk'] is too short >>> >>> From schema: Documentation/devicetree/bindings/phy/samsung,ufs- >> phy.yaml >>> >>> >>> and so on. It seems you miss there clocks. >> >> +Cc Alim. >> >> Tesla FSD has the same problem: >> tesla/fsd-evb.dtb: ufs-phy@15124000: clocks: [[35, 2]] is too short >> > > Thanks for the report. > Ufs-phy clock of Fsd and Exynos Auto v9 shall be 'ref' clock only unlike previous exynos7's ufs-phy. > > I'm looking into how I can fix the warning. > I simply made below patch but I'm not sure which is better between minItems/maxItems and oneOf selection. > > --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > @@ -28,17 +28,23 @@ properties: > > clocks: > items: > - - description: PLL reference clock > - - description: symbol clock for input symbol ( rx0-ch0 symbol clock) > - - description: symbol clock for input symbol ( rx1-ch1 symbol clock) > - - description: symbol clock for output symbol ( tx0 symbol clock) > + minItems: 1 > + maxItems: 4 > + items: > + - description: PLL reference clock > + - description: symbol clock for input symbol ( rx0-ch0 symbol clock) > + - description: symbol clock for input symbol ( rx1-ch1 symbol clock) > + - description: symbol clock for output symbol ( tx0 symbol clock) > > clock-names: > - items: > - - const: ref_clk > - - const: rx1_symbol_clk > - - const: rx0_symbol_clk > - - const: tx0_symbol_clk > + oneOf: > + - items: > + - const: ref_clk > + - const: rx1_symbol_clk > + - const: rx0_symbol_clk > + - const: tx0_symbol_clk > + - items: > + - const: ref_clk > You need: 1. new compatible 2. min/maxItems in clocks/clock-names in "properties:" part. 3. allOf:if:then: adding constraints per variant to clocks and clock-names. See: https://elixir.bootlin.com/linux/v5.18-rc2/source/Documentation/devicetree/bindings/clock/samsung,exynos7885-clock.yaml#L53 Best regards, Krzysztof
