On Thu, 30 Jun 2022 at 10:11, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 30/06/2022 07:59, Sam Protsenko wrote: > > Hi Chanho, > > > > On Thu, 30 Jun 2022 at 05:19, Chanho Park <chanho61.park@xxxxxxxxxxx> wrote: > >> > >> Add samsung,exynosautov9-uart dedicated compatible for representing > >> usi of Exynos Auto v9 SoC. > >> > >> Signed-off-by: Chanho Park <chanho61.park@xxxxxxxxxxx> > >> --- > >> .../devicetree/bindings/soc/samsung/exynos-usi.yaml | 8 ++++++-- > >> 1 file changed, 6 insertions(+), 2 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml > >> index fde886a8cf43..6e806e950a36 100644 > >> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml > >> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml > >> @@ -22,8 +22,12 @@ properties: > >> pattern: "^usi@[0-9a-f]+$" > >> > >> compatible: > >> - enum: > >> - - samsung,exynos850-usi # for USIv2 (Exynos850, ExynosAutoV9) > >> + oneOf: > >> + - items: > >> + - const: samsung,exynosautov9-usi > >> + - const: samsung,exynos850-usi > >> + - enum: > >> + - samsung,exynos850-usi # for USIv2 (Exynos850, ExynosAutoV9) > >> > > > > Why "samsung,exynos850-usi" is duplicated? Maybe it would be correct > > to leave only "items" and remove the "enum"? > > It has to be like this. Either you use exynos850-usi directly (on > Exynos850) or as a fallback (on Autov9). > Thanks for the explanation, I never thought about that case before, though noticed that pattern in bindings long ago. > Best regards, > Krzysztof
