On 02/06/2022 15:04, Chanho Park wrote:
>>> @@ -75,7 +75,7 @@ static int samsung_ufs_phy_wait_for_lock_acq(struct
>>> phy *phy) static int samsung_ufs_phy_calibrate(struct phy *phy) {
>>> struct samsung_ufs_phy *ufs_phy = get_samsung_ufs_phy(phy);
>>> - struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfg;
>>> + const struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfg;
>>
>> This should be rather array of const pointers to const data.
>
> The prototype of ufs_phy->cfg is 'const struct samsung_ufs_phy_cfg **' by this patch.
> So, it should be,
>
> const struct samsung_ufs_phy_cfg ** const cfgs = ufs_phy->cfg;
Not entirely, that would be const pointer (array) of pointers to const
data. What you want is:
const struct samsung_ufs_phy_cfg * const * cfgs = ufs_phy->cfg;
Best regards,
Krzysztof
