RE: [PATCH v2 1/6] dt-bindings: phy: samsung,ufs-phy: make pmu-syscon as phandle-array

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >>    samsung,pmu-syscon:
> >> -    $ref: '/schemas/types.yaml#/definitions/phandle'
> >> -    description: phandle for PMU system controller interface, used to
> >> -                 control pmu registers bits for ufs m-phy
> >> +    $ref: '/schemas/types.yaml#/definitions/phandle-array'
> >> +    items:
> >> +      minItems: 1
> >> +      items:
> >> +        - description: phandle for PMU system controller interface, used
> to
> >> +                       control pmu registers bits for ufs m-phy
> >> +        - description: offset of the pmu control register
> >
> > This does not work... Please test your bindings with different cases.
> 
> Just to be clear - when I mentioned that minItems should be on second
> items level, I meant it should affect the second items list, not the first.
> Now you can have 1, 2 or 10 phandles.

I put the minItems to the second level as you mentioned but I got below error from dt_binding_check.

--- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
@@ -42,8 +42,8 @@ properties:
   samsung,pmu-syscon:
     $ref: '/schemas/types.yaml#/definitions/phandle-array'
     items:
-      minItems: 1
       items:
+        - minItems: 1
         - description: phandle for PMU system controller interface, used to
                        control pmu registers bits for ufs m-phy
         - description: offset of the pmu control register

$ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
ufs-phy@15571800: samsung,pmu-syscon:0: [4294967295, 1828] is too short

Best Regards,
Chanho Park





[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux for Synopsys ARC Processors]    
  • [Linux on Unisoc (RDA Micro) SoCs]     [Linux Actions SoC]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  •   Powered by Linux