On 17/05/2022 20:45, Anand Moon wrote: > Hi Krzysztof, > > On Sun, 15 May 2022 at 15:18, Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> On 15/05/2022 08:41, Anand Moon wrote: >>> Add runtime power management for exynos thermal driver. >> >> First of all - why? Second, I do not see it being added. Where are the >> runtime callbacks? >> > > To control runtime control PMU, did I miss something? Controlling runtime PM by itself is not a goal. What does it change if it is enabled? > I looked into imx thermal driver # drivers/thermal/imx_thermal.c > to enable run-time power management for exynos driver. So you have runtime PM enabled and then what happens? Where is the power saving? Since you did not implement the callbacks, all this should be explained in commit msg. Best regards, Krzysztof
