Hi Krzysztof, On Mon, 16 May 2022 at 16:14, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On 16/05/2022 12:42, kernel test robot wrote: > > Hi Anand, > > > > Thank you for the patch! Perhaps something to improve: > > > > [auto build test WARNING on ec7f49619d8ee13e108740c82f942cd401b989e9] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Anand-Moon/Exynos-Thermal-code-inprovement/20220515-144336 > > base: ec7f49619d8ee13e108740c82f942cd401b989e9 > > config: hexagon-randconfig-r033-20220516 (https://download.01.org/0day-ci/archive/20220516/202205161820.8rHIcsvI-lkp@xxxxxxxxx/config) > > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 853fa8ee225edf2d0de94b0dcbd31bea916e825e) > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # https://github.com/intel-lab-lkp/linux/commit/eb50b0c2100fabd6d09b87abd11f52c5295512e8 > > git remote add linux-review https://github.com/intel-lab-lkp/linux > > git fetch --no-tags linux-review Anand-Moon/Exynos-Thermal-code-inprovement/20220515-144336 > > git checkout eb50b0c2100fabd6d09b87abd11f52c5295512e8 > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/thermal/samsung/ > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > > > All warnings (new ones prefixed by >>): > > > >>> drivers/thermal/samsung/exynos_tmu.c:929:40: warning: overlapping comparisons always evaluate to false [-Wtautological-overlap-compare] > > if (data->soc == SOC_ARCH_EXYNOS5420 && > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ > > 1 warning generated. > > Ah, I did not notice it and it seems code was not compile-tested with W=1. > > Anand, please be sure you compile your code with W=1... > Ok I will try to resolve this warning in the next version. > > Best regards, > Krzysztof Thanks & Regards -Anand
