Hi Krzysztof, On Sun, 15 May 2022 at 15:11, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 15/05/2022 08:41, Anand Moon wrote: > > Reorder the tmu_gpu clock initialization for exynos5422 SoC. > > Why? It just code reorder > > > > > Cc: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> > > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx> > > --- > > v1: split the changes and improve the commit messages > > --- > > drivers/thermal/samsung/exynos_tmu.c | 43 ++++++++++++++-------------- > > 1 file changed, 21 insertions(+), 22 deletions(-) > > > > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c > > index 75b3afadb5be..1ef90dc52c08 100644 > > --- a/drivers/thermal/samsung/exynos_tmu.c > > +++ b/drivers/thermal/samsung/exynos_tmu.c > > @@ -1044,42 +1044,41 @@ static int exynos_tmu_probe(struct platform_device *pdev) > > dev_err(&pdev->dev, "Failed to get clock\n"); > > ret = PTR_ERR(data->clk); > > goto err_sensor; > > - } > > - > > - data->clk_sec = devm_clk_get(&pdev->dev, "tmu_triminfo_apbif"); > > - if (IS_ERR(data->clk_sec)) { > > - if (data->soc == SOC_ARCH_EXYNOS5420_TRIMINFO) { > > - dev_err(&pdev->dev, "Failed to get triminfo clock\n"); > > - ret = PTR_ERR(data->clk_sec); > > - goto err_sensor; > > - } > > } else { > > - ret = clk_prepare_enable(data->clk_sec); > > + ret = clk_prepare_enable(data->clk); > > This looks a bit odd. The clock was before taken unconditionally, not > within "else" branch... The whole *clk_sec* ie tmu_triminfo_apbif clock enable is being moved down to the switch case. tmu_triminfo_apbif clock is not used by Exynos4412 and Exynos5433 and Exynos7 SoC. > > > Best regards, > Krzysztof Thanks & Regards -Anand