> On 02/05/2022 11:02, Chanho Park wrote: > > Add dt-schema for Exynos Auto v9 SoC clock controller. > > > > Signed-off-by: Chanho Park <chanho61.park@xxxxxxxxxxx> > > --- > > .../clock/samsung,exynosautov9-clock.yaml | 217 ++++++++++++++++++ > > 1 file changed, 217 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yam > > l > > > > diff --git > > a/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.y > > aml > > b/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.y > > aml > > new file mode 100644 > > index 000000000000..e2a01f50db6c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clo > > +++ ck.yaml > > @@ -0,0 +1,217 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > +https://protect2.fireeye.com/v1/url?k=fb45247c-9a3e8ef5-fb44af33-74fe > > +48600034-4889ba24b7242494&q=1&e=4fe6f8ce-5796-4b99-a99b-dde22be0ea01& > > +u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fclock%2Fsamsung%2Cexynosaut > > +ov9-clock.yaml%23 > > +$schema: > > +https://protect2.fireeye.com/v1/url?k=5feda469-3e960ee0-5fec2f26-74fe > > +48600034-d4fa399d62c830d8&q=1&e=4fe6f8ce-5796-4b99-a99b-dde22be0ea01& > > +u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 > > + > > +title: Samsung Exynos Auto v9 SoC clock controller > > + > > +maintainers: > > + - Chanho Park <chanho61.park@xxxxxxxxxxx> > > + - Chanwoo Choi <cw00.choi@xxxxxxxxxxx> > > + - Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > + - Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> > > + - Tomasz Figa <tomasz.figa@xxxxxxxxx> > > + > > +description: | > > + Exynos Auto v9 clock controller is comprised of several CMU units, > > +generating > > + clocks for different domains. Those CMU units are modeled as > > +separate device > > + tree nodes, and might depend on each other. Root clocks in that > > +clock tree are > > + two external clocks:: OSCCLK/XTCXO (26 MHz) and RTCCLK/XrtcXTI (32768 > Hz). > > + Those external clocks must be defined as fixed-rate clocks in dts. > > + > > + CMU_TOP is a top-level CMU, where all base clocks are prepared > > + using PLLs and dividers; all other clocks of function blocks (other > > + CMUs) are usually derived from CMU_TOP. > > + > > + Each clock is assigned an identifier and client nodes can use this > > + identifier to specify the clock which they consume. All clocks > > + available for usage in clock consumer nodes are defined as > > + preprocessor macros in 'dt-bindings/clock/exynosautov9.h' header. > > I know this follows Exynos850 pattern, but I would prefer to move towards: > 1. vendor,device: samsung,exynosautov9.h 2. put here full path, so > include/dt-bindings .... Okay. I'll change the file name to "samsung,exynosautov9.h". <snip> > > +additionalProperties: false > > + > > +examples: > > + # Clock controller node for CMU_FSYS2 > > + - | > > + #include <dt-bindings/clock/exynosautov9.h> > > + > > + cmu_fsys2: clock-controller@17c00000 { > > + compatible = "samsung,exynosautov9-cmu-fsys2"; > > + reg = <0x17c00000 0x8000>; > > + #clock-cells = <1>; > > + > > + clocks = <&xtcxo>, <&cmu_top DOUT_CLKCMU_FSYS2_BUS>, > > + <&cmu_top DOUT_CLKCMU_FSYS2_UFS_EMBD>, > > + <&cmu_top DOUT_CLKCMU_FSYS2_ETHERNET>; > > Let's put each item in its own line, so line break after every clock here > and in the clock-names. Make sense. I'll put each item in its own line. Best Regards, Chanho Park
