On Wed, Mar 30, 2022 at 05:22:56PM +0200, Neil Armstrong wrote:
> On 30/03/2022 11:18, Andy Shevchenko wrote:
...
> > > > > > What error do you hit ?
> > > > >
> > > > > arch/x86/include/asm/arch_hweight.h:9:17: error: expected identifier before string constant
> > > > > 9 | #define REG_OUT "a"
> > > > > | ^~~
> > > >
> > > > Perhaps REG_{OUT,IN} in arch/x86/include/asm/arch_hweight.h should be
> > > > renamed instead, as this is a generic header file that can be included
> > > > anywhere, while the REG_{OUT,IN} definitions are only used locally,
> > > > in the header file?
> > >
> > > Even better, those REG_OUT/REG_IN should be undefined at the end of the header since only
> > > used in the headers inline functions:
> > > ==============><==================================
> > > diff --git a/arch/x86/include/asm/arch_hweight.h b/arch/x86/include/asm/arch_hweight.h
> > > index ba88edd0d58b..139a4b0a2a14 100644
> > > --- a/arch/x86/include/asm/arch_hweight.h
> > > +++ b/arch/x86/include/asm/arch_hweight.h
> > > @@ -52,4 +52,7 @@ static __always_inline unsigned long __arch_hweight64(__u64 w)
> > > }
> > > #endif /* CONFIG_X86_32 */
> > >
> > > +#undef REG_IN
> > > +#undef REG_OUT
> > > +
> > > #endif
> > > ==============><==================================
> >
> > Can you submit a formal patch, please?
>
> I'll submit it separately
Sure!
> > And I think it would be good to have my patch as well, so we do not depend on
> > the fate of the other one.
>
> Yes sure
Thanks for acknowledging and review!
--
With Best Regards,
Andy Shevchenko
