Hi Andy,
On Tue, Mar 29, 2022 at 5:29 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> Switch the code to use for_each_gpiochip_node() helper.
>
> While at it, in order to avoid additional churn in the future,
> switch to fwnode APIs where it makes sense.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/pinctrl/renesas/pinctrl-rza1.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rza1.c
> @@ -1166,17 +1167,17 @@ static const struct pinmux_ops rza1_pinmux_ops = {
> * @range: pin range to register to pinctrl core
> */
> static int rza1_parse_gpiochip(struct rza1_pinctrl *rza1_pctl,
> - struct device_node *np,
> + struct fwnode_handle *fwnode,
> struct gpio_chip *chip,
> struct pinctrl_gpio_range *range)
> {
> const char *list_name = "gpio-ranges";
> - struct of_phandle_args of_args;
> + struct fwnode_reference_args of_args;
fw_args?
> unsigned int gpioport;
> u32 pinctrl_base;
> int ret;
>
> - ret = of_parse_phandle_with_fixed_args(np, list_name, 3, 0, &of_args);
> + ret = fwnode_property_get_reference_args(fwnode, list_name, NULL, 3, 0, &of_args);
> if (ret) {
> dev_err(rza1_pctl->dev, "Unable to parse %s list property\n",
> list_name);
> @@ -1197,13 +1198,12 @@ static int rza1_parse_gpiochip(struct rza1_pinctrl *rza1_pctl,
>
> *chip = rza1_gpiochip_template;
> chip->base = -1;
> - chip->label = devm_kasprintf(rza1_pctl->dev, GFP_KERNEL, "%pOFn",
> - np);
> + chip->label = devm_kasprintf(rza1_pctl->dev, GFP_KERNEL, "%pfw", fwnode);
This changes the label from e.g. "/soc/pinctrl@fcfe3000/gpio-11" to "gpio-11".
%pfwP?
> if (!chip->label)
> return -ENOMEM;
>
> chip->ngpio = of_args.args[2];
> - chip->of_node = np;
> + chip->fwnode = fwnode;
> chip->parent = rza1_pctl->dev;
>
> range->id = gpioport;
With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Acked-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
