On 20/03/2022 08:10, Christophe JAILLET wrote:
> 'dmc->counter' is a 'struct devfreq_event_dev **', so there is some
> over memory allocation. 'counters_size' should be computed with
> 'sizeof(struct devfreq_event_dev *)'.
>
> Use 'sizeof(*dmc->counter)' instead to fix it.
>
> While at it, use devm_kcalloc() instead of devm_kzalloc()+open coded
> multiplication.
>
> Fixes: 6e7674c3c6df ("memory: Add DMC driver for Exynos5422")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> devm_kmalloc_array() could also be used to save a few cycles because the
> array is fully initialized a few lines below.
> ---
> drivers/memory/samsung/exynos5422-dmc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
Thanks, looks good. I'll take it after merge window.
Best regards,
Krzysztof
