On 07/03/2022 09:50, Vincent Whitchurch wrote: > Add support for the UART on the ARTPEC-8 SoC. > > Signed-off-by: Vincent Whitchurch <vincent.whitchurch@xxxxxxxx> > --- > drivers/tty/serial/Kconfig | 2 +- > drivers/tty/serial/samsung_tty.c | 38 ++++++++++++++++++++++++++++++++ > 2 files changed, 39 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > index e952ec5c7a7c..ae120d3d933a 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -237,7 +237,7 @@ config SERIAL_CLPS711X_CONSOLE > > config SERIAL_SAMSUNG > tristate "Samsung SoC serial support" > - depends on PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS || ARCH_APPLE || COMPILE_TEST > + depends on PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS || ARCH_APPLE || ARCH_ARTPEC || COMPILE_TEST > select SERIAL_CORE > help > Support for the on-chip UARTs on the Samsung > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > index d002a4e48ed9..4f9e74c6bcef 100644 > --- a/drivers/tty/serial/samsung_tty.c > +++ b/drivers/tty/serial/samsung_tty.c > @@ -2837,6 +2837,36 @@ static struct s3c24xx_serial_drv_data s5l_serial_drv_data = { > #define S5L_SERIAL_DRV_DATA ((kernel_ulong_t)NULL) > #endif > > +#if defined(CONFIG_ARCH_ARTPEC) > +static struct s3c24xx_serial_drv_data artpec8_serial_drv_data = { This will conflict with my constifying patches: https://lore.kernel.org/all/20220307080810.53847-1-krzysztof.kozlowski@xxxxxxxxxxxxx/T/#t The code itself looks good. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> Best regards, Krzysztof