On 30/01/2022 01:22, Rob Herring wrote: > On Sat, 29 Jan 2022 18:53:31 +0100, Krzysztof Kozlowski wrote: >> Convert the Exynos5433 LPASS bindings to DT schema format. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> >> --- >> .../bindings/mfd/samsung,exynos5433-lpass.txt | 72 ----------- >> .../mfd/samsung,exynos5433-lpass.yaml | 119 ++++++++++++++++++ >> 2 files changed, 119 insertions(+), 72 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt >> create mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.example.dt.yaml: audio-subsystem@11400000: serial@11460000:compatible:0: 'samsung,exynos5433-uart' is not one of ['apple,s5l-uart', 'samsung,s3c2410-uart', 'samsung,s3c2412-uart', 'samsung,s3c2440-uart', 'samsung,s3c6400-uart', 'samsung,s5pv210-uart', 'samsung,exynos4210-uart', 'samsung,exynos850-uart'] > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml > Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.example.dt.yaml:0:0: /example-0/audio-subsystem@11400000/serial@11460000: failed to match any schema with compatible: ['samsung,exynos5433-uart'] > This is false positive or rather my patch-ordering issue. I fixed it up in patch 5/5 of this series. Best regards, Krzysztof