Re: [PATCH] spi: s3c24xx: Convert to GPIO descriptors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19/01/2022 01:09, Linus Walleij wrote:
> This driver has a bunch of custom oldstyle GPIO number-passing
> fields and a custom set-up callback.
> 
> The good thing is: nothing in the kernel is using it.
> 
> Convert the driver to use GPIO descriptors with a SPI_MASTER_GPIO_SS
> flag so that the local CS callback also get invoked as the hardware
> needs this.
> 
> New users of this driver can provide GPIO descriptor tables like
> the other converted drivers.
> 
> Cc: linux-samsung-soc@xxxxxxxxxxxxxxx
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> Cc: Sylwester Nawrocki <snawrocki@xxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
>  drivers/spi/spi-s3c24xx.c   | 47 +++----------------------------------
>  include/linux/spi/s3c24xx.h |  5 ----
>  2 files changed, 3 insertions(+), 49 deletions(-)
> 

LGTM:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>


Best regards,
Krzysztof



[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux for Synopsys ARC Processors]    
  • [Linux on Unisoc (RDA Micro) SoCs]     [Linux Actions SoC]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  •   Powered by Linux