On 14/01/2022 17:57, Alim Akhtar wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxxxxx] >> Sent: Thursday, January 13, 2022 6:03 PM >> To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; linux-arm- >> kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx >> Cc: soc@xxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; >> olof@xxxxxxxxx; linus.walleij@xxxxxxxxxx; catalin.marinas@xxxxxxx; >> robh+dt@xxxxxxxxxx; s.nawrocki@xxxxxxxxxxx; linux-samsung- >> soc@xxxxxxxxxxxxxxx; pankaj.dubey@xxxxxxxxxxx; linux-fsd@xxxxxxxxx >> Subject: Re: [PATCH 13/23] dt-bindings: arm: add Tesla FSD ARM SoC >> >> On 13/01/2022 13:11, Alim Akhtar wrote: >>> Add device tree bindings for the Tesla FSD ARM SoC. >>> >>> Cc: linux-fsd@xxxxxxxxx >>> Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> >>> --- >>> .../devicetree/bindings/arm/tesla.yaml | 25 +++++++++++++++++++ >>> 1 file changed, 25 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/arm/tesla.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/arm/tesla.yaml >>> b/Documentation/devicetree/bindings/arm/tesla.yaml >>> new file mode 100644 >>> index 000000000000..9f89cde76c85 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/arm/tesla.yaml >>> @@ -0,0 +1,25 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 >>> +--- >>> +$id: >>> +https://protect2.fireeye.com/v1/url?k=2f0fac44-70949546-2f0e270b-0cc4 >>> +7a312ab0-50c826f7b1999a5f&q=1&e=bcbf277f-4e93-4705-8f6a- >> 2beaa7eb31e2& >>> +u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Farm%2Ftesla.yaml%23 >>> +$schema: >>> +https://protect2.fireeye.com/v1/url?k=d8493fe2-87d206e0-d848b4ad-0cc4 >>> +7a312ab0-f4e5046adc7da972&q=1&e=bcbf277f-4e93-4705-8f6a- >> 2beaa7eb31e2& >>> +u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 >>> + >>> +title: Tesla Full Self Driving(FSD) platforms device tree bindings >>> + >>> +maintainers: >>> + - Alim Akhtar <alim.akhtar@xxxxxxxxxxx> >>> + - linux-fsd@xxxxxxxxx >>> + >>> +properties: >>> + $nodename: >>> + const: '/' >>> + compatible: >>> + oneOf: >>> + >>> + - description: FSD SoC board >>> + items: >>> + - const: tesla,fsd >> >> Either this is a SoC or a board compatible... Cannot be both. >> > Actually we call this as fsd board, so let me add accordingly compatible (fsd-baord) for board. > Thanks It's confusing and probably not accurate. In your series fsd is three things in the same time: an architecture, a SoC and a board (DTS). The last two should definitely be different. You probably have some eval board (how it is called also in Tesla open source git) or some specific product board. I cannot judge how different this is from Exynos subarchitecture - looking at patches it is not different - so I could understand a FSD sub-arch with only one SoC. Best regards, Krzysztof
