>-----Original Message----- >From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxxxxx] >Sent: Thursday, January 13, 2022 6:11 PM >To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; linux-arm- >kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx >Cc: soc@xxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; >olof@xxxxxxxxx; linus.walleij@xxxxxxxxxx; catalin.marinas@xxxxxxx; >robh+dt@xxxxxxxxxx; s.nawrocki@xxxxxxxxxxx; linux-samsung- >soc@xxxxxxxxxxxxxxx; pankaj.dubey@xxxxxxxxxxx; linux-fsd@xxxxxxxxx >Subject: Re: [PATCH 01/23] dt-bindings: clock: Document FSD CMU bindings > >On 13/01/2022 13:11, Alim Akhtar wrote: >> Add dt-schema documentation for Tesla FSD SoC clock controller. >> >> Cc: linux-fsd@xxxxxxxxx >> Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> >> --- >> .../bindings/clock/tesla,fsd-clock.yaml | 212 ++++++++++++++++++ >> 1 file changed, 212 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/clock/tesla,fsd-clock.yaml >> >> diff --git >> a/Documentation/devicetree/bindings/clock/tesla,fsd-clock.yaml >> b/Documentation/devicetree/bindings/clock/tesla,fsd-clock.yaml >> new file mode 100644 >> index 000000000000..58f341e5004d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/tesla,fsd-clock.yaml >> @@ -0,0 +1,212 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 >> +--- >> +$id: >> +https://protect2.fireeye.com/v1/url?k=7e607c7a-1f1d943d-7e61f735-74fe >> +485fff30-a4acf0e03cbf256d&q=1&e=05b30de9-b535-49f7-9359- >77edd951da07& >> +u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fclock%2Ftesla%2Cfsd- >clock.y >> +aml%23 >> +$schema: >> +https://protect2.fireeye.com/v1/url?k=5c769dcb-3d0b758c-5c771684-74fe >> +485fff30-b4007a892a5a3e44&q=1&e=05b30de9-b535-49f7-9359- >77edd951da07& >> +u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 >> + >> +title: Tesla FSD (Full Self-Driving) SoC clock controller >> + >> +maintainers: >> + - Alim Akhtar <alim.akhtar@xxxxxxxxxxx> >> + - linux-fsd@xxxxxxxxx >> + >> +description: | >> + FSD clock controller consist of several clock management unit >> + (CMU), which generates clocks for various inteernal SoC blocks. >> + The root clock comes from external OSC clock (24 MHz). >> + >> + All available clocks are defined as preprocessor macros in >> + 'dt-bindings/clock/fsd-clk.h' header. >> + >> +properties: >> + compatible: >> + enum: >> + - tesla,fsd-clock-cmu >> + - tesla,fsd-clock-imem >> + - tesla,fsd-clock-peric >> + - tesla,fsd-clock-fsys0 >> + - tesla,fsd-clock-fsys1 >> + - tesla,fsd-clock-mfc >> + - tesla,fsd-clock-cam_csi >> + >> + clocks: >> + minItems: 1 >> + maxItems: 6 >> + >> + clock-names: >> + minItems: 1 >> + maxItems: 6 >> + >> + "#clock-cells": >> + const: 1 >> + >> + reg: >> + maxItems: 1 >> + >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: tesla,fsd-clock-cmu >> + > >Nitpick: Drop the white-spaces between if-then. It's easier to spot the if- >blocks if they are together. > Thanks will fix in next version >> + then: >> + properties: >> + clocks: >> + items: >> + - description: External reference clock (24 MHz) >> + > >Drop this whitespace as well. > Noted >Rest looks good to me, except the discussion about the compatible. > Have replied to the original question thread. > >Best regards, >Krzysztof
