On Thu, Jan 13, 2022 at 4:32 AM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> wrote: > > On 13/01/2022 13:11, Alim Akhtar wrote: > > This patch set adds basic support for the Tesla Full Self-Driving (FSD) > > SoC. This SoC contains three clusters of four Cortex-A72 CPUs, > > as well as several IPs. > > > > Patches 1 to 8 provide support for the clock controller > > (which is designed similarly to Exynos SoCs). > > > > The remaining changes provide pinmux support, initial device tree support, > > and SPI, ADC, and MCT IP functionality. > > Does FSD have some version number? The FDS, especially in compatibles, > looks quite generic, so what will happen if a newer SoC comes later? You > would have: > - tesla,fsd-pinctrl > - tesla,fsd-xxxx-pinctrl (where xxxx could be some new version) > > This will be extra confusing, because fsd-pinctrl looks like the generic > one, while it is specific... The public sources from Tesla on github uses "turbo,trav" here, but that's also not a versioned name. The platform itself (hw3/hw31 -- 3.1 I presume?) has numbering, but that's system and not SoC: https://github.com/teslamotors/linux/tree/tesla-4.14-hw3/arch/arm64/boot/dts/turbo It would be easy to do "fsd2" for naming/numbering if needed for future versions, for example. I'm not so worried about this, especially if there's no corresponding internal version numbering that this would map naturally to. -Olof
