On 30/12/2021 20:34, Krzysztof Kozlowski wrote: > Hi Chanho and Sam, > > I am slowly finishing dtschema for Samsung pinctrl drivers [1] and I > noticed that Exynos850 and Auto v9 do not define interrupt in pinctrl > node with: wakeup-interrupt-controller. This is an interrupt muxing > several external wakeup interrupts, e.g. EINT16 - EINT31. > > For Exynos5433 this looks like: > https://elixir.bootlin.com/linux/latest/source/arch/arm64/boot/dts/exynos/exynos5433.dtsi#L857 > > Missing muxed interrupt for Exynos850 and Autov9 might be fine, although > you should see in dmesg error log like: > "irq number for muxed EINTs not found" > > Can you check that your wakeup-interrupt-controller is properly defined > in DTSI? If yes, I will need to include such differences in the dtschema. > Exynos850 DTSI additionally defines 32 interrupts for ALIVE pinctrl and 8 for CMGP. This looks suspicious - driver does not support multiple interupts and how would they even work? What would be the source? It seems that Exynos850 should move these interrupts to wakeup pinctrl banks (actually - they are defined there!). I'll send a patch for this. > [1] https://github.com/krzk/linux/tree/n/dt-bindings-samsung-pinctrl-schema > > Best regards, > Krzysztof > Best regards, Krzysztof
