17.12.2021 02:56, Matthias Kaehlcke пишет: > On Tue, Nov 16, 2021 at 12:07:39PM -0800, Matthias Kaehlcke wrote: >> Some USB controller drivers that depend on the xhci-plat driver >> specify this dependency using 'select' in Kconfig. This is not >> recommended for symbols that have other dependencies as it may >> lead to invalid configurations. Use 'depends on' to specify the >> dependency instead of 'select'. >> >> For dwc3 specify the dependency on USB_XHCI_PLATFORM in >> USB_DWC3_HOST and USB_DWC3_DUAL_ROLE. Also adjust the >> dependencies of USB_DWC3_CORE to make sure that at least one >> of USB_DWC3_HOST, USB_DWC3_GADGET or USB_DWC3_DUAL_ROLE can be >> selected. >> >> Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> >> Reviewed-by: Roger Quadros <rogerq@xxxxxxxxxx> >> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > > Note: This patch has been removed from the onboard_usb_hub series, > together with "ARM: configs: Explicitly enable USB_XHCI_PLATFORM > where needed" and "arm64: defconfig: Explicitly enable > USB_XHCI_PLATFORM". These patches aren't any longer needed for the > series. If maintainers think they are useful independently from > the series please pick them or let me know what needs to be > changed to get them landed. > Hi, I don't know what this all is about, perhaps I'm CC'ed semi-randomly because touched that Kconfig once. All I can say here is that the commit message tells us "This is not recommended" and doesn't explain what's the actual problem is being solved. If there is no real problem, why bother?
