Hi, > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> > Sent: Wednesday, December 8, 2021 6:15 PM > To: Chanho Park <chanho61.park@xxxxxxxxxxx>; Rob Herring > <robh+dt@xxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linux-samsung-soc@xxxxxxxxxxxxxxx; Sam Protsenko > <semen.protsenko@xxxxxxxxxx> > Subject: Re: [PATCH] arm64: dts: exynosautov9: convert serial_0 for USI > > On 08/12/2021 01:39, Chanho Park wrote: > > According to USI v2 driver change[1], serial_0 node should be > > converted to use the USI node hierarchy. syscon_peric0 will be used as > > a syscon node to control the USI00_USI_SW_CONF register. > > This also changes the serial node name from uart@ to serial@. > > > > [1]: > > https://lore.kernel.org/linux-samsung-soc/20211204195757.8600-2-semen. > > protsenko@xxxxxxxxxx/ > > > > Cc: Sam Protsenko <semen.protsenko@xxxxxxxxxx> > > Signed-off-by: Chanho Park <chanho61.park@xxxxxxxxxxx> > > --- > > .../boot/dts/exynos/exynosautov9-sadk.dts | 4 +++ > > arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 36 > > ++++++++++++++----- > > 2 files changed, 32 insertions(+), 8 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts > > b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts > > index ef46d7aa6e28..6cc903443809 100644 > > --- a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts > > +++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts > > @@ -41,6 +41,10 @@ ufs_0_fixed_vcc_reg: regulator-0 { > > }; > > }; > > > > +&usi_0 { > > + status = "okay"; > > +}; > > + > > Put this one alphabetically in DTS. Regarding usi / serial/hsi2c/spi nodes, I thought it looks better to keep the order of DTSi. Anyway, I'll follow alphabetical order in DTS. I'll apply this next patch. Best Regards, Chanho Park