On 31/10/2021 13:22, Sam Protsenko wrote: > When "tmr_atboot" module param is set, the watchdog is started in > driver's probe. In that case, also set WDOG_HW_RUNNING bit to let > watchdog core driver know it's running. This way watchdog core can kick > the watchdog for us (if CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED option is > enabled), until user space takes control. > > WDOG_HW_RUNNING bit must be set before registering the watchdog. So the > "tmr_atboot" handling code is moved before watchdog registration, to > avoid performing the same check twice. This is also logical because > WDOG_HW_RUNNING bit makes WDT core expect actually running watchdog. > > Signed-off-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx> > --- > Changes in v2: > - Added explanation on moving the code block to commit message > - [PATCH 03/12] handles the case when tmr_atboot is present but valid > timeout wasn't found > > drivers/watchdog/s3c2410_wdt.c | 26 +++++++++++++++----------- > 1 file changed, 15 insertions(+), 11 deletions(-) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> Best regards, Krzysztof
