On 15.10.2021 17:16, Krzysztof Kozlowski wrote: > On 15/10/2021 17:14, Sylwester Nawrocki wrote: >> Remove useless __init atrribute and unneeded extern qualifier in function >> declarations in header files. >> >> Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> >> --- >> drivers/clk/samsung/clk-cpu.h | 2 +- >> drivers/clk/samsung/clk.h | 34 +++++++++++++++++----------------- [..] >> -extern void __init samsung_clk_register_pll(struct samsung_clk_provider *ctx, >> +void samsung_clk_register_pll(struct samsung_clk_provider *ctx, >> const struct samsung_pll_clock *pll_list, >> unsigned int nr_clk, void __iomem *base); >> -extern void samsung_clk_register_cpu(struct samsung_clk_provider *ctx, >> +void samsung_clk_register_cpu(struct samsung_clk_provider *ctx, >> const struct samsung_cpu_clock *list, unsigned int nr_clk); [...] > In such case, let's also drop the extern from Will's patch? Yeah, I have already applied Will's patches and that patch also removes the one newly introduced extern. -- Regards, Sylwester
