On 14/10/2021 13:25, Sam Protsenko wrote: > On Thu, 14 Oct 2021 at 09:41, Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxxxxx> wrote: >> >> On 13/10/2021 22:21, Sam Protsenko wrote: >>> Old Exynos SoCs have both Product ID and Revision ID in one single >>> register, while new SoCs tend to have two separate registers for those >>> IDs. Implement handling of both cases by passing Revision ID register >>> offsets in driver data. >>> >>> Signed-off-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx> >>> --- >>> drivers/soc/samsung/exynos-chipid.c | 67 +++++++++++++++++++---- >>> include/linux/soc/samsung/exynos-chipid.h | 6 +- >>> 2 files changed, 58 insertions(+), 15 deletions(-) >>> >>> diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c >>> index 5c1d0f97f766..7837331fb753 100644 >>> --- a/drivers/soc/samsung/exynos-chipid.c >>> +++ b/drivers/soc/samsung/exynos-chipid.c >>> @@ -16,6 +16,7 @@ >>> #include <linux/errno.h> >>> #include <linux/mfd/syscon.h> >>> #include <linux/of.h> >>> +#include <linux/of_device.h> >>> #include <linux/platform_device.h> >>> #include <linux/regmap.h> >>> #include <linux/slab.h> >>> @@ -24,6 +25,17 @@ >> >> Include a changelog please. Your patch does not apply and there is no >> information on tree which it was based on. >> > > Sorry, my bad. Will do in v3. As for the tree: it's based on the > latest mainline/master. I'll double check if patches apply correctly > to that before sending v3. Please let me know if you want me to rebase > this series on top of some other tree. Mainline/master won't work in most of the cases. You need to rebase your work on maintainer's tree. This is sometimes tricky, so usually it's enough to base on linux-next. In this case, either use linux-next or for-next branch of my tree: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/ Best regards, Krzysztof
