On Wed, 15 Sept 2021 at 16:07, Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> wrote: > > On 14.09.2021 17:56, Sam Protsenko wrote: > > +static void __init exynos850_cmu_top_init(struct device_node *np) > > +{ > > + exynos850_init_clocks(np, top_clk_regs, ARRAY_SIZE(top_clk_regs)); > > + samsung_cmu_register_one(np, &top_cmu_info); > > +} > > + > > +CLK_OF_DECLARE(exynos850_cmu_top, "samsung,exynos850-cmu-top", > > + exynos850_cmu_top_init); > > Was there anything preventing you from making it a platform driver instead? > Can you please elaborate on benefits of adding platform driver? I don't implement PM ops for now, and I can see that clk-exynos7.c does not add platform driver as well... clk-exynos5433.c seems to use platform_driver for PM ops only. > -- > Regards, > Sylwester