On Wed, 02 Jun 2021, Krzysztof Kozlowski wrote: > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > Interrupt line can be configured on different hardware in different way, > even inverted. Therefore driver should not enforce specific trigger > type - edge falling - but instead rely on Devicetree to configure it. > > The Maxim 14577/77836 datasheets describe the interrupt line as active > low with a requirement of acknowledge from the CPU therefore the edge > falling is not correct. > > The interrupt line is shared between PMIC and charger driver, so using > level sensitive interrupt is here especially important to avoid races. > With an edge configuration in case if first PMIC signals interrupt > followed shortly after by the RTC, the interrupt might not be yet > cleared/acked thus the second one would not be noticed. > > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Acked-by: Rob Herring <robh@xxxxxxxxxx> > > --- > > Changes since v1: > 1. Add Ack > --- > Documentation/devicetree/bindings/mfd/max14577.txt | 4 ++-- > drivers/mfd/max14577.c | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
