>-----Original Message----- >From: Chanho Park [mailto:chanho61.park@xxxxxxxxxxx] >Sent: Friday, September 17, 2021 12:24 PM >To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; Avri Altman ><avri.altman@xxxxxxx>; James E . J . Bottomley <jejb@xxxxxxxxxxxxx>; Martin >K . Petersen <martin.petersen@xxxxxxxxxx>; Krzysztof Kozlowski ><krzysztof.kozlowski@xxxxxxxxxxxxx> >Cc: Bean Huo <beanhuo@xxxxxxxxxx>; Bart Van Assche ><bvanassche@xxxxxxx>; Adrian Hunter <adrian.hunter@xxxxxxxxx>; Christoph >Hellwig <hch@xxxxxxxxxxxxx>; Can Guo <cang@xxxxxxxxxxxxxx>; Jaegeuk Kim ><jaegeuk@xxxxxxxxxx>; Gyunghoon Kwon <goodjob.kwon@xxxxxxxxxxx>; >linux-samsung-soc@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; Chanho Park ><chanho61.park@xxxxxxxxxxx>; Kiwoong Kim <kwmad.kim@xxxxxxxxxxx> >Subject: [PATCH v3 08/17] scsi: ufs: ufs-exynos: add setup_clocks callback > >This patch adds setup_clocks callback to control/gate clocks by ufshcd. >To avoid calling before initialization, it needs to check whether ufs is null or not >and call it initially from pre_link callback. > >Cc: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> >Cc: Kiwoong Kim <kwmad.kim@xxxxxxxxxxx> >Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> >Signed-off-by: Chanho Park <chanho61.park@xxxxxxxxxxx> >--- > drivers/scsi/ufs/ufs-exynos.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > >diff --git a/drivers/scsi/ufs/ufs-exynos.c b/drivers/scsi/ufs/ufs-exynos.c index >627edef4fbeb..2024e44a09d7 100644 >--- a/drivers/scsi/ufs/ufs-exynos.c >+++ b/drivers/scsi/ufs/ufs-exynos.c >@@ -795,6 +795,27 @@ static void exynos_ufs_config_intr(struct exynos_ufs >*ufs, u32 errs, u8 index) > } > } > >+static int exynos_ufs_setup_clocks(struct ufs_hba *hba, bool on, >+ enum ufs_notify_change_status status) { >+ struct exynos_ufs *ufs = ufshcd_get_variant(hba); >+ >+ if (!ufs) >+ return 0; >+ >+ if (on) { >+ if (ufs->opts & EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL) >+ exynos_ufs_disable_auto_ctrl_hcc(ufs); >+ exynos_ufs_ungate_clks(ufs); >+ } else { >+ exynos_ufs_gate_clks(ufs); >+ if (ufs->opts & EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL) >+ exynos_ufs_enable_auto_ctrl_hcc(ufs); >+ } >+ >+ return 0; >+} >+ > static int exynos_ufs_pre_link(struct ufs_hba *hba) { > struct exynos_ufs *ufs = ufshcd_get_variant(hba); @@ -813,6 +834,8 >@@ static int exynos_ufs_pre_link(struct ufs_hba *hba) > exynos_ufs_config_phy_time_attr(ufs); > exynos_ufs_config_phy_cap_attr(ufs); > >+ exynos_ufs_setup_clocks(hba, true, POST_CHANGE); For consistency and better understanding, may be PRE_CHANGE? >+ > if (ufs->drv_data->pre_link) > ufs->drv_data->pre_link(ufs); > >@@ -1203,6 +1226,7 @@ static struct ufs_hba_variant_ops ufs_hba_exynos_ops >= { > .hce_enable_notify = exynos_ufs_hce_enable_notify, > .link_startup_notify = exynos_ufs_link_startup_notify, > .pwr_change_notify = exynos_ufs_pwr_change_notify, >+ .setup_clocks = exynos_ufs_setup_clocks, > .setup_xfer_req = >exynos_ufs_specify_nexus_t_xfer_req, > .setup_task_mgmt = exynos_ufs_specify_nexus_t_tm_req, > .hibern8_notify = exynos_ufs_hibern8_notify, >-- >2.33.0
