On 18/09/2021 09:02, Greg Kroah-Hartman wrote: > On Fri, Sep 17, 2021 at 07:51:33PM +0200, Krzysztof Kozlowski wrote: >> In case if soc-bus drivers are modules soc_device_to_device() has to be >> exported. Since it is trivial, export it as non-GPL. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> >> --- >> drivers/base/soc.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/base/soc.c b/drivers/base/soc.c >> index 0af5363a582c..ac8db303daa1 100644 >> --- a/drivers/base/soc.c >> +++ b/drivers/base/soc.c >> @@ -41,6 +41,7 @@ struct device *soc_device_to_device(struct soc_device *soc_dev) >> { >> return &soc_dev->dev; >> } >> +EXPORT_SYMBOL(soc_device_to_device); > > I thought we were getting rid of the use of this function, why export it > and not just fix it up instead? > > Or am I confused about some other soc device abuse... I was not aware of discussion about soc_device_to_device(). Thanks for pointing out the issue. I googled a little and found previous talks: https://lore.kernel.org/lkml/20191111052741.GB3176397@xxxxxxxxx/ I can easily get rid of soc_device_to_device() in my driver, so first patch won't be needed. Best regards, Krzysztof