Hi Inki, I love your patch! Yet something to improve: [auto build test ERROR on drm-exynos/exynos-drm-next] [also build test ERROR on drm-intel/for-linux-next drm-tip/drm-tip tegra-drm/drm/tegra/for-next v5.13-rc3 next-20210525] [cannot apply to drm/drm-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Inki-Dae/drm-exynos-use-pm_runtime_resume_and_get/20210525-190630 base: https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next config: arm64-randconfig-r014-20210526 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 99155e913e9bad5f7f8a247f8bb3a3ff3da74af1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/0day-ci/linux/commit/e9c82df302b53764b0fac4c14d48efe2595a296e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Inki-Dae/drm-exynos-use-pm_runtime_resume_and_get/20210525-190630 git checkout e9c82df302b53764b0fac4c14d48efe2595a296e # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/gpu/drm/exynos/exynos_drm_gsc.c:1123:47: error: too few arguments provided to function-like macro invocation dev_err("failed to enable GScaler device.\n"); ^ include/linux/dev_printk.h:111:9: note: macro 'dev_err' defined here #define dev_err(dev, fmt, ...) \ ^ >> drivers/gpu/drm/exynos/exynos_drm_gsc.c:1123:3: error: use of undeclared identifier 'dev_err'; did you mean '_dev_err'? dev_err("failed to enable GScaler device.\n"); ^~~~~~~ _dev_err include/linux/dev_printk.h:50:6: note: '_dev_err' declared here void _dev_err(const struct device *dev, const char *fmt, ...); ^ drivers/gpu/drm/exynos/exynos_drm_gsc.c:1123:3: warning: expression result unused [-Wunused-value] dev_err("failed to enable GScaler device.\n"); ^~~~~~~ 1 warning and 2 errors generated. vim +1123 drivers/gpu/drm/exynos/exynos_drm_gsc.c 1114 1115 static int gsc_commit(struct exynos_drm_ipp *ipp, 1116 struct exynos_drm_ipp_task *task) 1117 { 1118 struct gsc_context *ctx = container_of(ipp, struct gsc_context, ipp); 1119 int ret; 1120 1121 ret = pm_runtime_resume_and_get(ctx->dev); 1122 if (ret < 0) { > 1123 dev_err("failed to enable GScaler device.\n"); 1124 return ret; 1125 } 1126 1127 ctx->task = task; 1128 1129 ret = gsc_reset(ctx); 1130 if (ret) { 1131 pm_runtime_put_autosuspend(ctx->dev); 1132 ctx->task = NULL; 1133 return ret; 1134 } 1135 1136 gsc_src_set_fmt(ctx, task->src.buf.fourcc, task->src.buf.modifier); 1137 gsc_src_set_transf(ctx, task->transform.rotation); 1138 gsc_src_set_size(ctx, &task->src); 1139 gsc_src_set_addr(ctx, 0, &task->src); 1140 gsc_dst_set_fmt(ctx, task->dst.buf.fourcc, task->dst.buf.modifier); 1141 gsc_dst_set_size(ctx, &task->dst); 1142 gsc_dst_set_addr(ctx, 0, &task->dst); 1143 gsc_set_prescaler(ctx, &ctx->sc, &task->src.rect, &task->dst.rect); 1144 gsc_start(ctx); 1145 1146 return 0; 1147 } 1148 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
