On 22.04.2021 12:46, Krzysztof Kozlowski wrote: > On 22/04/2021 12:41, Łukasz Stelmach wrote: >> pm_runtime_get_sync() increments the runtime PM usage counter even >> the call returns an error code. Thus a pairing decrement is needed >> on the error handling path to keep the counter balanced. > It's exactly the same as Dinghao's patch: > https://lore.kernel.org/linux-samsung-soc/20200522011659.26727-1-dinghao.liu@xxxxxxxxxx/ > which you reviewed. It has even the same commit msg > (although it's difficult to be creative here). > > I think it's better to resend his patch instead. Frankly speaking I would get rid of the pm_runtime_get_sync() calls in the drivers and replace them with pm_runtime_resume_and_get() to finish that never ending pm_runtime get/put misunderstanding soap opea... Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
