On 16/04/2021 04:19, zhuguangqing83@xxxxxxxxx wrote: > From: Guangqing Zhu <zhuguangqing83@xxxxxxxxx> > > Coccinelle noticed: > 1. drivers/rtc/rtc-s5m.c:810:7-32: ERROR: Threaded IRQ with no primary > handler requested without IRQF_ONESHOT > 2. drivers/rtc/rtc-rk808.c:441:7-32: ERROR: Threaded IRQ with no primary > handler requested without IRQF_ONESHOT > 3. drivers/rtc/rtc-max77686.c:779:7-27: ERROR: Threaded IRQ with no primary > handler requested without IRQF_ONESHOT > 4. drivers/rtc/rtc-tps65910.c:415:7-32: ERROR: Threaded IRQ with no primary > handler requested without IRQF_ONESHOT > 5. drivers/rtc/rtc-lp8788.c:277:8-33: ERROR: Threaded IRQ with no primary > handler requested without IRQF_ONESHOT > 6. drivers/rtc/rtc-max8998.c:283:7-32: ERROR: Threaded IRQ with no primary > handler requested without IRQF_ONESHOT > 7. drivers/rtc/rtc-rc5t583.c:241:7-32: ERROR: Threaded IRQ with no primary > handler requested without IRQF_ONESHOT > 8. drivers/rtc/rtc-max8997.c:495:7-32: ERROR: Threaded IRQ with no primary > handler requested without IRQF_ONESHOT > > Signed-off-by: Guangqing Zhu <zhuguangqing83@xxxxxxxxx> > --- > drivers/rtc/rtc-lp8788.c | 2 +- > drivers/rtc/rtc-max77686.c | 4 ++-- > drivers/rtc/rtc-max8997.c | 2 +- > drivers/rtc/rtc-max8998.c | 3 ++- > drivers/rtc/rtc-rc5t583.c | 2 +- > drivers/rtc/rtc-rk808.c | 2 +- > drivers/rtc/rtc-s5m.c | 4 ++-- > drivers/rtc/rtc-tps65910.c | 2 +- > 8 files changed, 11 insertions(+), 10 deletions(-) > The same with all other patches for IRQF_ONESHOT which are send recently: 1. On what board did you test it? 2. Is this just blind patch from Coccinelle without investigation whether it is needed (hint: it might not be needed in all of these places, because at least some of them do not use default primary handler). 3. If you think otherwise, please explain. Best regards, Krzysztof
