On Fri, Jan 22, 2021 at 02:15:18PM +0100, Linus Walleij wrote: > On Thu, Jan 21, 2021 at 4:00 AM Chanho Park <chanho61.park@xxxxxxxxxxx> wrote: > > > This patch converts spin_[lock|unlock] functions of pin bank to > > raw_spinlock to support preempt-rt. This can avoid BUG() assertion when > > irqchip callbacks are triggerred. Spinlocks can be converted rt_mutex > > which is preemptible when we apply preempt-rt patches. > > > > According to "Documentation/driver-api/gpio/driver.rst", > > > > "Realtime considerations: a realtime compliant GPIO driver should not > > use spinlock_t or any sleepable APIs (like PM runtime) as part of its > > irqchip implementation. > > > > - spinlock_t should be replaced with raw_spinlock_t.[1] > > " > > > > Cc: Tomasz Figa <tomasz.figa@xxxxxxxxx> > > Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > Cc: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> > > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > > Signed-off-by: Chanho Park <chanho61.park@xxxxxxxxxxx> > > Looks correct to me. > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > Krzysztof, will you collect Samsung patches for this merge window or > shall I apply it directly? I don't have anything in the queue so far and I don't see any patches incomming, so maybe take it directly? Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> Best regards, Krzysztof
