On Fri, 4 Dec 2020 at 16:28, Sylwester Nawrocki <snawrocki@xxxxxxxxxx> wrote: > > From: Arnd Bergmann <arnd@xxxxxxxx> > > The use of SIMPLE_DEV_PM_OPS() means that the suspend/resume > functions are now unused when CONFIG_PM is disabled: > > drivers/clk/samsung/clk-exynos-clkout.c:219:12: error: > 'exynos_clkout_resume' defined but not used [-Werror=unused-function] > 219 | static int exynos_clkout_resume(struct device *dev) > | ^~~~~~~~~~~~~~~~~~~~ > drivers/clk/samsung/clk-exynos-clkout.c:210:12: error: > 'exynos_clkout_suspend' defined but not used [-Werror=unused-function] > 210 | static int exynos_clkout_suspend(struct device *dev) > | ^~~~~~~~~~~~~~~~~~~~~ > > Mark them as __maybe_unused to shut up the otherwise harmless warning. > > Fixes: 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to module > driver") > Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > --- > v2: add proper changelog text > > Acked-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> Indeed this should go via samsung soc tree... Best regards, Krzysztof