On Fri, Nov 13, 2020 at 10:51:19PM +0800, xiakaixu1987@xxxxxxxxx wrote:
> From: Kaixu Xia <kaixuxia@xxxxxxxxxxx>
>
> The value of variable ret is overwritten by the following call
> devm_snd_soc_register_card(), so here the value assignment is useless.
> Remove it.
>
> Reported-by: Tosk Robot <tencent_os_robot@xxxxxxxxxxx>
Where can we find the report?
> Signed-off-by: Kaixu Xia <kaixuxia@xxxxxxxxxxx>
> ---
> sound/soc/samsung/smdk_wm8994.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/samsung/smdk_wm8994.c b/sound/soc/samsung/smdk_wm8994.c
> index 64a1a64..1db5b59 100644
> --- a/sound/soc/samsung/smdk_wm8994.c
> +++ b/sound/soc/samsung/smdk_wm8994.c
> @@ -160,11 +160,9 @@ static int smdk_audio_probe(struct platform_device *pdev)
> smdk_dai[0].cpus->dai_name = NULL;
> smdk_dai[0].cpus->of_node = of_parse_phandle(np,
> "samsung,i2s-controller", 0);
> - if (!smdk_dai[0].cpus->of_node) {
> + if (!smdk_dai[0].cpus->of_node)
> dev_err(&pdev->dev,
> "Property 'samsung,i2s-controller' missing or invalid\n");
> - ret = -EINVAL;
This should jump to out/return instead.
Please use script get_maintainers.pl to get the list of people and
mailing lists to Cc. No one would apply this patch otherwise...
Best regards,
Krzysztof
