On Wed, 28 Oct 2020 22:40:09 +0100, Łukasz Stelmach wrote: > Add bindings for AX88796C SPI Ethernet Adapter. > > Signed-off-by: Łukasz Stelmach <l.stelmach@xxxxxxxxxxx> > --- > .../bindings/net/asix,ax88796c.yaml | 69 +++++++++++++++++++ > 1 file changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/asix,ax88796c.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/net/asix,ax88796c.example.dts:23.13-25: Warning (reg_format): /example-0/ethernet@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1) Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: example-0: ethernet@0:reg:0: [0] is too short From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/asix,ax88796c.example.dt.yaml: ethernet@0: 'interrupt-parrent' is a required property From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/asix,ax88796c.yaml See https://patchwork.ozlabs.org/patch/1389785 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.