On Wed, Oct 14, 2020 at 04:52:23PM +0200, Thomas Gleixner wrote: > From: Ahmed S. Darwish <a.darwish@xxxxxxxxxxxxx> > > The usage of in_interrupt() in drivers is phased out for various reasons. > > Various comments use !in_interrupt() to describe calling context for probe() > and remove() functions. That's wrong because the calling context has to be > preemptible task context, which is not what !in_interrupt() describes. > > Cleanup the comments. While at it add the missing kernel doc argument > descriptors and make usb_hcd_msp_remove() static. > > Signed-off-by: Ahmed S. Darwish <a.darwish@xxxxxxxxxxxxx> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: linux-usb@xxxxxxxxxxxxxxx > Cc: linux-omap@xxxxxxxxxxxxxxx > Cc: Kukjin Kim <kgene@xxxxxxxxxx> > Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Cc: linux-samsung-soc@xxxxxxxxxxxxxxx > > --- > drivers/usb/host/ehci-fsl.c | 9 ++++----- > drivers/usb/host/ehci-pmcmsp.c | 15 +++++++++------ > drivers/usb/host/ohci-at91.c | 11 ++++++++--- > drivers/usb/host/ohci-omap.c | 7 ++++--- > drivers/usb/host/ohci-pxa27x.c | 11 ++++++----- > drivers/usb/host/ohci-s3c2410.c | 12 ++++++------ For the s3c2410: Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> Best regards, Krzysztof
