Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> --- drivers/mfd/tc3589x.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c index 7882a37ffc35..22821112cc6b 100644 --- a/drivers/mfd/tc3589x.c +++ b/drivers/mfd/tc3589x.c @@ -287,7 +287,8 @@ static int tc3589x_device_init(struct tc3589x *tc3589x) unsigned int blocks = tc3589x->pdata->block; if (blocks & TC3589x_BLOCK_GPIO) { - ret = mfd_add_devices(tc3589x->dev, -1, tc3589x_dev_gpio, + ret = mfd_add_devices(tc3589x->dev, PLATFORM_DEVID_NONE, + tc3589x_dev_gpio, ARRAY_SIZE(tc3589x_dev_gpio), NULL, 0, tc3589x->domain); if (ret) { @@ -298,7 +299,8 @@ static int tc3589x_device_init(struct tc3589x *tc3589x) } if (blocks & TC3589x_BLOCK_KEYPAD) { - ret = mfd_add_devices(tc3589x->dev, -1, tc3589x_dev_keypad, + ret = mfd_add_devices(tc3589x->dev, PLATFORM_DEVID_NONE, + tc3589x_dev_keypad, ARRAY_SIZE(tc3589x_dev_keypad), NULL, 0, tc3589x->domain); if (ret) { -- 2.17.1