It was <2020-08-25 wto 10:19>, when Randy Dunlap wrote: > On 8/25/20 10:03 AM, Łukasz Stelmach wrote: >> diff --git a/drivers/net/ethernet/asix/Kconfig b/drivers/net/ethernet/asix/Kconfig >> new file mode 100644 >> index 000000000000..4b127a4a659a >> --- /dev/null >> +++ b/drivers/net/ethernet/asix/Kconfig >> @@ -0,0 +1,20 @@ >> +# >> +# Asix network device configuration >> +# >> + >> +config NET_VENDOR_ASIX >> + bool "Asix devices" > > Most vendor entries also have: > default y > so that they will be displayed in the config menu. OK. >> + depends on SPI >> + help >> + If you have a network (Ethernet) interface based on a chip from ASIX, say Y >> + >> +if NET_VENDOR_ASIX >> + >> +config SPI_AX88796C >> + tristate "Asix AX88796C-SPI support" >> + depends on SPI > > That line is redundant (but not harmful). Why? Is it because NET_VENDOR_ASIX depends on SPI? Probably it shouldn't. Thanks for spotting. >> + depends on GPIOLIB >> + help >> + Say Y here if you intend to attach a Asix AX88796C as SPI mode >> + >> +endif # NET_VENDOR_ASIX -- Łukasz Stelmach Samsung R&D Institute Poland Samsung Electronics
Attachment:
signature.asc
Description: PGP signature