2020年8月17日(月) 18:57 Krzysztof Kozlowski <krzk@xxxxxxxxxx>: > > On Tue, Aug 04, 2020 at 09:26:47PM +0200, Krzysztof Kozlowski wrote: > > A separate Kconfig option HAVE_S3C2410_WATCHDOG for Samsung SoCs is not > > really needed and the s3c24xx watchdog driver can depend on Samsung ARM > > architectures instead. > > > > The "HAVE_xxx_WATCHDOG" pattern of dependency is not popular and Samsung > > platforms are here exceptions. All others just depend on > > CONFIG_ARCH_xxx. > > > > This makes the code slightly smaller without any change in > > functionality. > > > > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > > > --- > > > > Changes since v1: > > 1. Re-add the dependency on architectures to keep same functionality. > > Hi Guenter, Tomasz, > > Does such removal of HAVE_S3C2410_WATCHDOG makes sense for you? I don't have any objections and the patch itself is trivial. Best regards, Tomasz