On Wed, Aug 12, 2020 at 12:46 PM Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> wrote: > On 12.08.2020 11:14, Arnd Bergmann wrote: > > > > It seems there have never been any callers and the entire file > > can just be removed, with the rest of that platform_data header > > file moved to drivers/media/platform/s3c-camif/. > > Yes, it seems that patch never made it to mainline: > https://git.linuxtv.org/snawrocki/media.git/commit/?h=testing/s3c-camif&id=355cbf835aff2aabf78390931cbbaa608af77967 I suppose it would still apply if anyone was interested, but I see your point. > I doubt there are still users of camera on the s3c2440 boards > with current mainline kernels, if any at all, there are much > better HW alternatives right now. I see two board files (and no DT) instantiate the camif device: NexVision Nexcoder 2440 and the FriendlyARM mini2440. Can you say whether the camif on those would actually work at all without your patch? If not, we know that there are no users of that driver and could either drop it completely or move it to staging for a release or two. Arnd