On Wed, Jul 29, 2020 at 07:49:02PM +0200, Tomasz Figa wrote: > 2020年7月29日(水) 18:11 Krzysztof Kozlowski <krzk@xxxxxxxxxx>: > > > > Remove the arch/arm/plat-samsung/include/plat/samsung-time.h header and > > move the contents to common.h headers in mach-s3c24xx and mach-s3c64xx. > > The definition of declared functions is already in common.c in mach > > directories, so it is logically to put declaration next to them. > > > > This is also one step further towards removal of plat-samsung directory > > and it fixes W=1 build warnings: > > > > arch/arm/mach-s3c64xx/common.c:174:13: warning: > > no previous prototype for 'samsung_set_timer_source' [-Wmissing-prototypes] > > 174 | void __init samsung_set_timer_source(unsigned int event, unsigned int source) > > > > arch/arm/mach-s3c64xx/common.c:180:13: warning: > > no previous prototype for 'samsung_timer_init' [-Wmissing-prototypes] > > 180 | void __init samsung_timer_init(void) > > > > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > --- > > arch/arm/mach-s3c24xx/common.h | 12 +++++++++ > > arch/arm/mach-s3c24xx/mach-amlm5900.c | 2 -- > > arch/arm/mach-s3c24xx/mach-anubis.c | 1 - > > arch/arm/mach-s3c24xx/mach-at2440evb.c | 1 - > > arch/arm/mach-s3c24xx/mach-bast.c | 1 - > > arch/arm/mach-s3c24xx/mach-gta02.c | 1 - > > arch/arm/mach-s3c24xx/mach-h1940.c | 1 - > > arch/arm/mach-s3c24xx/mach-jive.c | 1 - > > arch/arm/mach-s3c24xx/mach-mini2440.c | 1 - > > arch/arm/mach-s3c24xx/mach-n30.c | 1 - > > arch/arm/mach-s3c24xx/mach-nexcoder.c | 1 - > > arch/arm/mach-s3c24xx/mach-osiris.c | 1 - > > arch/arm/mach-s3c24xx/mach-otom.c | 1 - > > arch/arm/mach-s3c24xx/mach-qt2410.c | 1 - > > arch/arm/mach-s3c24xx/mach-rx1950.c | 1 - > > arch/arm/mach-s3c24xx/mach-rx3715.c | 1 - > > arch/arm/mach-s3c24xx/mach-smdk2410.c | 1 - > > arch/arm/mach-s3c24xx/mach-smdk2413.c | 1 - > > arch/arm/mach-s3c24xx/mach-smdk2416.c | 1 - > > arch/arm/mach-s3c24xx/mach-smdk2440.c | 1 - > > arch/arm/mach-s3c24xx/mach-smdk2443.c | 1 - > > arch/arm/mach-s3c24xx/mach-tct_hammer.c | 1 - > > arch/arm/mach-s3c24xx/mach-vr1000.c | 1 - > > arch/arm/mach-s3c24xx/mach-vstms.c | 1 - > > arch/arm/mach-s3c64xx/common.h | 13 ++++++++++ > > arch/arm/mach-s3c64xx/mach-anw6410.c | 1 - > > arch/arm/mach-s3c64xx/mach-crag6410.c | 1 - > > arch/arm/mach-s3c64xx/mach-hmt.c | 1 - > > arch/arm/mach-s3c64xx/mach-mini6410.c | 1 - > > arch/arm/mach-s3c64xx/mach-ncp.c | 1 - > > arch/arm/mach-s3c64xx/mach-real6410.c | 1 - > > arch/arm/mach-s3c64xx/mach-smartq.c | 1 - > > arch/arm/mach-s3c64xx/mach-smartq5.c | 1 - > > arch/arm/mach-s3c64xx/mach-smartq7.c | 1 - > > arch/arm/mach-s3c64xx/mach-smdk6400.c | 1 - > > arch/arm/mach-s3c64xx/mach-smdk6410.c | 1 - > > .../plat-samsung/include/plat/samsung-time.h | 26 ------------------- > > 37 files changed, 25 insertions(+), 61 deletions(-) > > delete mode 100644 arch/arm/plat-samsung/include/plat/samsung-time.h > > > > For the s3c64xx bits: > > Reviewed-by: Tomasz Figa <tomasz.figa@xxxxxxxxx> > > I suppose the next step would be renaming those functions to s3c24xx_* > and s3c64xx_* to avoid naming collisions? That's a good point. I will send a follow up patch. Thanks! Best regards, Krzysztof
