Hi Marek, I love your patch! Perhaps something to improve: [auto build test WARNING on pinctrl-samsung/for-next] [also build test WARNING on pinctrl/devel next-20200610] [cannot apply to v5.7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Marek-Szyprowski/pinctrl-samsung-Use-bank-name-as-irqchip-name/20200610-215115 base: https://git.kernel.org/pub/scm/linux/kernel/git/pinctrl/samsung.git for-next config: arm-defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>, old ones prefixed by <<): In file included from include/linux/device.h:15, from drivers/pinctrl/samsung/pinctrl-exynos.c:16: drivers/pinctrl/samsung/pinctrl-exynos.c: In function 'exynos_pinctrl_set_eint_wakeup_mask': >> drivers/pinctrl/samsung/pinctrl-exynos.c:370:4: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'u32 *' {aka 'unsigned int *'} [-Wformat=] 370 | "Setting external wakeup interrupt mask: 0x%xn", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt' 19 | #define dev_fmt(fmt) fmt | ^~~ >> drivers/pinctrl/samsung/pinctrl-exynos.c:369:2: note: in expansion of macro 'dev_info' 369 | dev_info(drvdata->dev, | ^~~~~~~~ drivers/pinctrl/samsung/pinctrl-exynos.c:370:48: note: format string is defined here 370 | "Setting external wakeup interrupt mask: 0x%xn", | ~^ | | | unsigned int | %n >> drivers/pinctrl/samsung/pinctrl-exynos.c:374:16: warning: passing argument 3 of 'regmap_write' makes integer from pointer without a cast [-Wint-conversion] 374 | irq_chip->eint_wake_mask_value); | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ | | | u32 * {aka unsigned int *} In file included from drivers/pinctrl/samsung/pinctrl-exynos.c:25: include/linux/regmap.h:1054:69: note: expected 'unsigned int' but argument is of type 'u32 *' {aka 'unsigned int *'} 1054 | int regmap_write(struct regmap *map, unsigned int reg, unsigned int val); | ~~~~~~~~~~~~~^~~ drivers/pinctrl/samsung/pinctrl-exynos.c: In function 's5pv210_pinctrl_set_eint_wakeup_mask': >> drivers/pinctrl/samsung/pinctrl-exynos.c:393:23: warning: passing argument 1 of '__raw_writel' makes integer from pointer without a cast [-Wint-conversion] 393 | __raw_writel(irq_chip->eint_wake_mask_value, | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ | | | u32 * {aka unsigned int *} In file included from include/linux/io.h:13, from include/linux/irq.h:20, from drivers/pinctrl/samsung/pinctrl-exynos.c:19: arch/arm/include/asm/io.h:93:37: note: expected 'u32' {aka 'unsigned int'} but argument is of type 'u32 *' {aka 'unsigned int *'} 93 | static inline void __raw_writel(u32 val, volatile void __iomem *addr) | ~~~~^~~ vim +370 drivers/pinctrl/samsung/pinctrl-exynos.c ad350cd9d54113 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-17 355 b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 356 static void b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 357 exynos_pinctrl_set_eint_wakeup_mask(struct samsung_pinctrl_drv_data *drvdata, b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 358 struct exynos_irq_chip *irq_chip) b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 359 { b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 360 struct regmap *pmu_regs; b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 361 b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 362 if (!drvdata->retention_ctrl || !drvdata->retention_ctrl->priv) { b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 363 dev_warn(drvdata->dev, b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 364 "No retention data configured bank with external wakeup interrupt. Wake-up mask will not be set.\n"); b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 365 return; b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 366 } b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 367 b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 368 pmu_regs = drvdata->retention_ctrl->priv; b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 @369 dev_info(drvdata->dev, b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 @370 "Setting external wakeup interrupt mask: 0x%x\n", b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 371 irq_chip->eint_wake_mask_value); b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 372 b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 373 regmap_write(pmu_regs, irq_chip->eint_wake_mask_reg, b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 @374 irq_chip->eint_wake_mask_value); b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 375 } b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 376 b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 377 static void b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 378 s5pv210_pinctrl_set_eint_wakeup_mask(struct samsung_pinctrl_drv_data *drvdata, b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 379 struct exynos_irq_chip *irq_chip) b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 380 b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 381 { b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 382 void __iomem *clk_base; b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 383 b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 384 if (!drvdata->retention_ctrl || !drvdata->retention_ctrl->priv) { b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 385 dev_warn(drvdata->dev, b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 386 "No retention data configured bank with external wakeup interrupt. Wake-up mask will not be set.\n"); b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 387 return; b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 388 } b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 389 b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 390 b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 391 clk_base = (void __iomem *) drvdata->retention_ctrl->priv; b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 392 b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 @393 __raw_writel(irq_chip->eint_wake_mask_value, b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 394 clk_base + irq_chip->eint_wake_mask_reg); b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 395 } b577a279914085 drivers/pinctrl/samsung/pinctrl-exynos.c Jonathan Bakker 2020-04-04 396 :::::: The code at line 370 was first introduced by commit :::::: b577a279914085c6b657c33e9f39ef56d96a3302 pinctrl: samsung: Correct setting of eint wakeup mask on s5pv210 :::::: TO: Jonathan Bakker <xc-racer2@xxxxxxx> :::::: CC: Krzysztof Kozlowski <krzk@xxxxxxxxxx> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
