On 5/19/20 12:26, Marek Szyprowski wrote:
> Mark the SCLK clock for Exynos5433 I2S1 device with IGNORE_UNUSED flag to
> match its behaviour with SCLK clock for AUD_I2S (I2S0) device until
> a proper fix for Exynos I2S driver is ready.
>
> This fixes the following synchronous abort issue revealed by the probe
> order change caused by the commit 93d2e4322aa ("of: platform: Batch fwnode
> parsing when adding all top level devices"):
> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
I will take a look an will see if we can get rid of these CLK_IGNORE_UNUSED
flags by modifying the I2S controller driver. Applying the patch for now.
> ---
> drivers/clk/samsung/clk-exynos5433.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
> index ed159beab34e..a111fc29352c 100644
> --- a/drivers/clk/samsung/clk-exynos5433.c
> +++ b/drivers/clk/samsung/clk-exynos5433.c
> @@ -1706,7 +1706,8 @@ static const struct samsung_gate_clock peric_gate_clks[] __initconst = {
> GATE(CLK_SCLK_PCM1, "sclk_pcm1", "sclk_pcm1_peric",
> ENABLE_SCLK_PERIC, 7, CLK_SET_RATE_PARENT, 0),
> GATE(CLK_SCLK_I2S1, "sclk_i2s1", "sclk_i2s1_peric",
> - ENABLE_SCLK_PERIC, 6, CLK_SET_RATE_PARENT, 0),
> + ENABLE_SCLK_PERIC, 6,
> + CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, 0),
> GATE(CLK_SCLK_SPI2, "sclk_spi2", "sclk_spi2_peric", ENABLE_SCLK_PERIC,
> 5, CLK_SET_RATE_PARENT, 0),
> GATE(CLK_SCLK_SPI1, "sclk_spi1", "sclk_spi1_peric", ENABLE_SCLK_PERIC,
--
Regards,
Sylwester
