On Fri, May 08, 2020 at 06:13:38AM -0700, Bernard Zhao wrote: > Maybe dmc->df->lock is unnecessary to protect function > exynos5_dmc_perf_events_check(dmc). If we have to protect, > dmc->lock is more better and more effective. > Also, it seems not needed to protect "if (ret) & dev_warn" > branch. > > Signed-off-by: Bernard Zhao <bernard@xxxxxxxx> > --- > drivers/memory/samsung/exynos5422-dmc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) I checked the concurrent accesses and it looks correct. Lukasz, any review from your side? Best regards, Krzysztof
