Hi Randy > -----Original Message----- > From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Sent: 11 May 2020 08:43 > To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; robh@xxxxxxxxxx > Cc: devicetree@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; krzk@xxxxxxxxxx; > avri.altman@xxxxxxx; martin.petersen@xxxxxxxxxx; > kwmad.kim@xxxxxxxxxxx; stanley.chu@xxxxxxxxxxxx; > cang@xxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v8 09/10] scsi: ufs-exynos: add UFS host support for Exynos > SoCs > > On 5/10/20 7:00 PM, Alim Akhtar wrote: > > diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig index > > e2005aeddc2d..cc7e29c8c24f 100644 > > --- a/drivers/scsi/ufs/Kconfig > > +++ b/drivers/scsi/ufs/Kconfig > > @@ -160,3 +160,15 @@ config SCSI_UFS_BSG > > > > Select this if you need a bsg device node for your UFS controller. > > If unsure, say N. > > + > > +config SCSI_UFS_EXYNOS > > + bool "EXYNOS specific hooks to UFS controller platform driver" > > + depends on SCSI_UFSHCD_PLATFORM && ARCH_EXYNOS || > COMPILE_TEST > > Since && has higher precedence than ||, I am thinking that this should be > > depends on SCSI_UFSHCD_PLATFORM && (ARCH_EXYNOS || > COMPILE_TEST) > Sure, I missed this, will add in next version. > > + select PHY_SAMSUNG_UFS > > + help > > + This selects the EXYNOS specific additions to UFSHCD platform driver. > > + UFS host on EXYNOS includes HCI and UNIPRO layer, and associates > with > > + UFS-PHY driver. > > + > > + Select this if you have UFS host controller on EXYNOS chipset. > > + If unsure, say N. > > > -- > ~Randy