On Wed, Mar 18, 2020 at 6:42 PM Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> wrote: > From: afzal mohammed <afzal.mohd.ma@xxxxxxxxx> > > request_irq() is preferred over setup_irq(). The early boot setup_irq() > invocations happen either via 'init_IRQ()' or 'time_init()', while > memory allocators are ready by 'mm_init()'. > > Per tglx[1], setup_irq() existed in olden days when allocators were not > ready by the time early interrupts were initialized. > > Hence replace setup_irq() by request_irq(). > > Seldom remove_irq() usage has been observed coupled with setup_irq(), > wherever that has been found, it too has been replaced by free_irq(). > > A build error that was reported by kbuild test robot <lkp@xxxxxxxxx> > in the previous version of the patch also has been fixed. > > [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos > > Signed-off-by: afzal mohammed <afzal.mohd.ma@xxxxxxxxx> > Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> > Link: https://lore.kernel.org/r/91961c77c1cf93d41523f5e1ac52043f32f97077.1582799709.git.afzal.mohd.ma@xxxxxxxxx Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> It is definitely the right thing to do, I cannot test it right now but if desired I can test it on my targets later in the following weeks. Yours, Linus Walleij
