Hi Paul,
On 13.03.2020 15:33, Paul Cercueil wrote:
> Hi Krzysztof,
>
>
> Le ven., mars 13, 2020 at 10:00, Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> a écrit :
>> On Thu, Mar 12, 2020 at 04:34:11PM +0100, Paul Cercueil wrote:
>>> From: Stenkin Evgeniy <stenkinevgeniy@xxxxxxxxx>
>>>
>>> Add devicetree file for the Exynos 4210 based Galaxy S2 (i9100
>>> version).
> [...]
> +
>>> +
>>> + memory@40000000 {
>>> + device_type = "memory";
>>> + reg = <0x40000000 0x40000000>;
>>> + };
>>> +
>>
>> You do not have a chosen node, at least for stdout serial selection.
>> Probably you should have one... bootargs I guess could come from
>> bootloader.
>
> Problem is, I have no idea which UART is available via the USB jig :)
See exynos4210-trats.dts and exynos4210-universal_c210.dts, they are
similar to i9100 and share a lots. They all use serial2 for debug UART
via USB jig.
>>> + vemmc_reg: regulator-0 {
>>> + compatible = "regulator-fixed";
>>> + regulator-name = "VMEM_VDD_2.8V";
>>> + regulator-min-microvolt = <2800000>;
>>> + regulator-max-microvolt = <2800000>;
>>> + gpio = <&gpk0 2 GPIO_ACTIVE_HIGH>;
>>> + enable-active-high;
>>
>> This looks like a stub/fake regulator. Probably it shoould be replaced
>> with proper regulator coming from PMIC (few seems to be missing there).
>>
>> I don't have the schematics so I cannot judge... I see Trats has the
>> same.
>>
>> Marek, mayybe you know, is it really a separate regulator?
Trats has the same regulator and according to the schematic it is
supplied from VBAT and controlled via eMMC_EN GPIO pin.
> > [...]
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
