Re: [PATCH 1/2] tty: serial: samsung_tty: build it for any platform

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 20, 2020 at 1:13 PM Bartlomiej Zolnierkiewicz
<b.zolnierkie@xxxxxxxxxxx> wrote:
> On 2/20/20 11:26 AM, Greg Kroah-Hartman wrote:
> > There is no need to tie this driver to only a specific SoC, or compile
> > test, so remove that dependancy from the Kconfig rules.
>
> samsung_tty driver is hardware specific driver so why should we
> build it for any platform?
>
> This change seems to defeat the whole purpose behind COMPILE_TEST
> config option (which allows us to build hardware-specific drivers
> without needlessly presenting the user with tons of non-relevant
> config options).
>
> Please explain this change some more, are you planing to remove
> COMPILE_TEST config option?

+1

I was just going to send a revert...

> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

> > --- a/drivers/tty/serial/Kconfig
> > +++ b/drivers/tty/serial/Kconfig
> > @@ -237,7 +237,6 @@ config SERIAL_CLPS711X_CONSOLE
> >
> >  config SERIAL_SAMSUNG
> >       tristate "Samsung SoC serial support"
> > -     depends on PLAT_SAMSUNG || ARCH_EXYNOS || COMPILE_TEST
> >       select SERIAL_CORE
> >       help
> >         Support for the on-chip UARTs on the Samsung S3C24XX series CPUs,
> >
> > base-commit: 11a48a5a18c63fd7621bb050228cebf13566e4d8

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux for Synopsys ARC Processors]    
  • [Linux on Unisoc (RDA Micro) SoCs]     [Linux Actions SoC]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  •   Powered by Linux