Hi Krzyszotof,
On 05.12.2019 21:00, Krzysztof Kozlowski wrote:
> Few options KALLSYMS_ALL, SCSI, PM_DEVFREQ and mutex/spinlock debugging
> were removed with savedefconfig because they were selected by other
> options. However these are user-visible options and they might not be
> selected in the future. Exactly this happened with commit 0e4a459f56c3
> ("tracing: Remove unnecessary DEBUG_FS dependency") removing the
> dependency between DEBUG_FS and TRACING.
>
> To avoid losing these options in the future, explicitly mention them in
> defconfig.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
I will not mind adding:
Reported-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
as this patch is a direct result of the discussion on my initial patch:
https://patchwork.kernel.org/patch/11260361/
and my previous findings.
> ---
> arch/arm/configs/exynos_defconfig | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index e7e4bb5ad8d5..026407101cf2 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -38,6 +38,7 @@ CONFIG_CRYPTO_SHA256_ARM=m
> CONFIG_CRYPTO_SHA512_ARM=m
> CONFIG_CRYPTO_AES_ARM_BS=m
> CONFIG_CRYPTO_CHACHA20_NEON=m
> +CONFIG_KALLSYMS_ALL=y
> CONFIG_MODULES=y
> CONFIG_MODULE_UNLOAD=y
> CONFIG_PARTITION_ADVANCED=y
> @@ -92,6 +93,7 @@ CONFIG_BLK_DEV_LOOP=y
> CONFIG_BLK_DEV_CRYPTOLOOP=y
> CONFIG_BLK_DEV_RAM=y
> CONFIG_BLK_DEV_RAM_SIZE=8192
> +CONFIG_SCSI=y
> CONFIG_BLK_DEV_SD=y
> CONFIG_CHR_DEV_SG=y
> CONFIG_ATA=y
> @@ -291,6 +293,7 @@ CONFIG_CROS_EC_SPI=y
> CONFIG_COMMON_CLK_MAX77686=y
> CONFIG_COMMON_CLK_S2MPS11=y
> CONFIG_EXYNOS_IOMMU=y
> +CONFIG_PM_DEVFREQ=y
> CONFIG_DEVFREQ_GOV_PERFORMANCE=y
> CONFIG_DEVFREQ_GOV_POWERSAVE=y
> CONFIG_DEVFREQ_GOV_USERSPACE=y
> @@ -355,4 +358,7 @@ CONFIG_SOFTLOCKUP_DETECTOR=y
> # CONFIG_DETECT_HUNG_TASK is not set
> CONFIG_PROVE_LOCKING=y
> CONFIG_DEBUG_ATOMIC_SLEEP=y
> +CONFIG_DEBUG_RT_MUTEXES=y
> +CONFIG_DEBUG_SPINLOCK=y
> +CONFIG_DEBUG_MUTEXES=y
> CONFIG_DEBUG_USER=y
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
