On 18.10.2019 06:30, Viresh Kumar wrote: > On 17-10-19, 12:27, Marek Szyprowski wrote: >> All the drivers, which use the OPP framework control regulators, which >> are already enabled. Typically those regulators are also system critical, >> due to providing power to CPU core or system buses. It turned out that >> there are cases, where calling regulator_enable() on such boot-enabled >> regulator has side-effects and might change its initial voltage due to >> performing initial voltage balancing without all restrictions from the >> consumers. Until this issue becomes finally solved in regulator core, >> avoid calling regulator_enable()/disable() from the OPP framework. >> >> This reverts commit 7f93ff73f7c8c8bfa6be33bcc16470b0b44682aa. >> >> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> >> --- >> This is a follow-up from the following discussion: >> https://lkml.org/lkml/2019/10/9/541 > I suppose this must go the v5.4-rcs, right ? Yes, please. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland